JBPM-3813 Process Instance Diagram in jBPM Console shows wrong multiple ... #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le markers due to the ordering of JPAProcessInstanceDbLog.findNodeInstances()
|
I believe this could have impact on existing implementations (if someone has used this method and relied on the order) as it will change the order of events from: to: N1_ENTER maybe as mentioned in jira it's better to apply filtering/sorting on graph plugin only instead. Wdyt? |
|
as agreed in jira, closing this pull request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Process Instance Diagram in jBPM Console shows wrong multiple markers due to the ordering of JPAProcessInstanceDbLog.findNodeInstances()
https://issues.jboss.org/browse/JBPM-3813
This pull request is a candidate fix which ensures that an ENTER log comes before an EXIT log. But I'm not sure if I'm right about assuming 'order by type' gives asc order in time line.