JBPM-4586 - Removal of loops with calls to Thread.sleep().

[baldimir]

See JIRA: https://issues.jboss.org/browse/JBPM-4586

[psiroky]

Based on the previous code, shouldn't the wait be 2500ms? Or maybe the 1200ms is wrong and the process indeed takes 1000ms?

[baldimir]

I made some changes to this. Take a look if it is OK. The main difference is that I created a constant that defines extra time needed for Thread.sleep() calls so the extra sleep time should be easily configurable in the future. Now it is 250ms. I think that this should be enough now to cover all tests that are in StartEventTest class because now there are no loops with Thread.sleep().

[mswiderski]

just tried to merge this but several builds fails with this:
Failed tests:
StartEventTest.testTimerStartCron:227->Assert.assertEquals:542->Assert.assertEquals:555->Assert.assertEquals:118->Assert.failNotEquals:743->Assert.fail:88 expected:<5> but was:<6>
StartEventTest.testTimerStartCron:227->Assert.assertEquals:542->Assert.assertEquals:555->Assert.assertEquals:118->Assert.failNotEquals:743->Assert.fail:88 expected:<5> but was:<6>

[baldimir]

Hmm... Strange. I tested it several times. OK I will recheck it on Monday.

[baldimir]

Changed the cron test so it waits approximately the same time as it was before (5s as was before, but without Thread.sleep in cycle). Tested it again, it should work.

[mswiderski]

merged into master, thanks @baldimir !