[6.4.x] RHBPMS-4184,JBPM-5277 - getTasksAssignedAsPotentialOwner doesn't allow groups searching, only actorid #560
Conversation
| @@ -0,0 +1,50 @@ | |||
| /* | |||
| * Copyright 2015 Red Hat, Inc. and/or its affiliates. | |||
mrietveld
force-pushed
the
pr-RHBPMS-4184-6.4.x
branch
from
59b23b3
to
d687f1e
Compare
| t.archived = 0 and | ||
| potOwners.id in (:groupIds) and | ||
| TYPE(potOwners) = 'Group' | ||
| order by t.id DESC |
There was a problem hiding this comment.
Minor thing, but the lines in the from and where blocks should be indented for better readability.
There was a problem hiding this comment.
Fixed. Last Jira, so what the heck?
mrietveld
force-pushed
the
pr-RHBPMS-4184-6.4.x
branch
from
d687f1e
to
b94f406
Compare
…w groups searching, only actorid
mrietveld
force-pushed
the
pr-RHBPMS-4184-6.4.x
branch
from
b94f406
to
7d04f13
Compare
| public void claimNextAvailable(String userId, List<String> groupIds) { | ||
| executor.execute(new ClaimNextAvailableTaskCommand(userId)); | ||
| } | ||
|
|
There was a problem hiding this comment.
@psiroky See above (re: claim and claimNextAvailable)
| Map<String, Object> params = new HashMap<String, Object>(); | ||
| params.put("groupIds", groupIds); | ||
| return (List<TaskSummary>) persistenceContext.queryWithParametersInTransaction( | ||
| "TasksByPotentialOwnerGroups", |
There was a problem hiding this comment.
Possibly another bikeshed, but to be consistent with the naming in the other classes, should we use different name for the query, e.g. TasksByGroups?
There was a problem hiding this comment.
Uhm.. If you insist on it, I'm happy to change it.
However, "TasksByPotentialOwnerGroups" describes exactly what the query does -- whereas "TasksByGroups" implies that the query is something else than what it is! For that reason, I'd like to keep the name to what it is, "TasksByPotentialOwnerGroups".
The operation name (getTasksByGroup) was decided by @krisv -- if you think it should be called something else, please talk to him.
|
@mbiarnes This PR needs to be merged for the release. Thanks! |
|
+1 |
Related to the release this week.
PR Set: