DROOLS-1434 Refactor core API and FEEL API into kie-dmn-api module #34
Conversation
| import org.kie.dmn.api.core.DMNMessage.Severity; | ||
| import org.kie.dmn.api.feel.runtime.events.FEELEvent; | ||
|
|
||
| public interface InternalDMNResult extends DMNResult { |
There was a problem hiding this comment.
to differentiate of the "immutable" already-existing DMNResult
| import org.kie.dmn.api.core.DMNType; | ||
| import org.kie.dmn.feel.model.v1_1.BusinessKnowledgeModel; | ||
|
|
||
| public interface BusinessKnowledgeModelNode extends DMNNode { |
There was a problem hiding this comment.
These AST node interfaces are needed to properly type for events (package org.kie.dmn.api.core.event)
| import org.kie.dmn.api.core.ast.EvaluatorResult; | ||
| import org.kie.dmn.api.core.ast.DMNExpressionEvaluator.ResultType; | ||
|
|
||
| public class EvaluatorResultImpl implements EvaluatorResult { |
There was a problem hiding this comment.
This class was a child subclass of the DMNExpressionEvaluator interface
|
|
||
| enum ResultType { | ||
| SUCCESS, FAILURE; | ||
| } | ||
|
|
||
| class EvaluatorResult { |
There was a problem hiding this comment.
EvaluatorResult is now a non-child interface, which later kie-dmn-core provide a concrete implementation EvaluatorResultImpl for.
|
@tarilabs lets talk tomorrow about this PR |
tarilabs
force-pushed
the
tarilabs-20170209
branch
from
276aa38
to
3c83640
Compare
|
@tarilabs I think it looks good, I am just moving the |
Initial proposal I'm going to comment in the relevant parts below.