Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KieScanner behavior for already existing KieBases and KieSessions #21

Merged
merged 1 commit into from
Dec 3, 2015

Conversation

tarilabs
Copy link
Member

@tarilabs tarilabs commented Dec 2, 2015

With reference to Drools-usage Google group discussion Ref.
https://groups.google.com/d/topic/drools-usage/XpFlRNjuc9c/discussion

Report below summary for reference.

I think statement is missing to describe
what happens to already existing KieSession and KieBase; from the
current description I would have assumed only "new" stuff gets
up-to-date, but (fortunately!) also some type of already-existing
KieSession and KieBase gets automatically updated.

Current behavior "From this moment on" proved by code actually is:

1- already existing KieBase, generated with getKieBase() : it does get
automatically updated. This is the use case of named KieBase or default
KieBase referenced from kmodule.xml

2- already existing KieBase, generated with newKieBase() : NOT
automatically updated. This is the use case of KieBase created with
"custom" KieBaseConfiguration settings and NOT referencing kmodule.xml

3- any KieBase generated after the KieScanner updated, with either
getKieBase() or newKieBase() : directly the newer version, simple case,
indeed as already mentioned in the documentation.

Behavior for already existing KieSession depends on the underlying
KieBase, so it make reference to the cases described here-above.
To be fully explicit, when already existing KieSession was generated
directly from KieContainer.newKieSession() is case #1 because it implies
the default KieBase from kmodule.xml.

With reference to Drools-usage Google group discussion Ref.
https://groups.google.com/d/topic/drools-usage/XpFlRNjuc9c/discussion

Report below summary for reference.

I think statement is missing to describe
what happens to already existing KieSession and KieBase; from the
current description I would have assumed only "new" stuff gets
up-to-date, but (fortunately!) also some type of already-existing
KieSession and KieBase gets automatically updated.

Current behavior "From this moment on" proved by code actually is:

1- already existing KieBase, generated with getKieBase() : it does get
automatically updated. This is the use case of named KieBase or default
KieBase referenced from kmodule.xml 

2- already existing KieBase, generated with newKieBase() : NOT
automatically updated. This is the use case of KieBase created with
"custom" KieBaseConfiguration settings and NOT referencing kmodule.xml

3- any KieBase generated after the KieScanner updated, with either
getKieBase() or newKieBase() : directly the newer version, simple case,
indeed as already mentioned in the documentation.

Behavior for already existing KieSession depends on the underlying
KieBase, so it make reference to the cases described here-above. 
To be fully explicit, when already existing KieSession was generated
directly from KieContainer.newKieSession() is case #1 because it implies
the default KieBase from kmodule.xml.
@kie-ci
Copy link

kie-ci commented Dec 2, 2015

Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

@psiroky
Copy link
Contributor

psiroky commented Dec 3, 2015

@mariofusco could you please take a look?

@mariofusco mariofusco merged commit 2550d14 into apache:master Dec 3, 2015
ChristyWatkins pushed a commit that referenced this pull request Oct 30, 2017
* BXMSDOC-1766 resolving merge conflicts

* Merge pull request #21 from emmurphy1/BXMSDOC-1766-master

Bxmsdoc 1766 master

* BXMSDOC-1766 added case management to main.adoc to avoid MC
vidya-iyengar pushed a commit that referenced this pull request Sep 21, 2018
* most work done on both Rostering docs

* more information on building etc

* SME review

* finishing SME revire

* SME and QE review changes

* peer review results

* removed s2i
vidya-iyengar pushed a commit that referenced this pull request Sep 21, 2018
* most work done on both Rostering docs

* more information on building etc

* SME review

* finishing SME revire

* SME and QE review changes

* peer review results

* removed s2i
sterobin pushed a commit that referenced this pull request Jun 4, 2020
…er dependency (#2449)

* BXMSDOC-5825: changed the version of version for cxf-rt-rs-service-description-swagger dependency (#21)

* BXMSDOC-5825: Changed last updated date

Co-authored-by: Heena Manwani <hmanwani@hmanwani.pnq.csb>
sterobin pushed a commit that referenced this pull request Jun 4, 2020
vidya-iyengar pushed a commit that referenced this pull request Jun 5, 2020
… cxf-rt-rs-service-description-swagger dependency (#2458)

* BXMSDOC-5825: changed the version of version for cxf-rt-rs-service-description-swagger dependency (#21)

* BXMSDOC-5825: Changed last updated date

Co-authored-by: Heena Manwani <hmanwani@hmanwani.pnq.csb>
vidya-iyengar pushed a commit that referenced this pull request Jun 5, 2020
… cxf-rt-rs-service-description-swagger dependency (#2459)

* BXMSDOC-5825: changed the version of version for cxf-rt-rs-service-description-swagger dependency (#21)

* BXMSDOC-5825: Changed last updated date

Co-authored-by: Heena Manwani <hmanwani@hmanwani.pnq.csb>
vidya-iyengar pushed a commit that referenced this pull request Jun 5, 2020
… cxf-rt-rs-service-description-swagger dependency (#2460)

* BXMSDOC-5825: changed the version of version for cxf-rt-rs-service-description-swagger dependency (#21)

* BXMSDOC-5825: changed last updated date

Co-authored-by: Heena Manwani <hmanwani@hmanwani.pnq.csb>
vidya-iyengar pushed a commit that referenced this pull request Jun 5, 2020
… cxf-rt-rs-service-description-swagger dependency (#2461)

* BXMSDOC-5825: changed the version of version for cxf-rt-rs-service-description-swagger dependency (#21)

* BXMSDOC-5825: changed last updated date

Co-authored-by: Heena Manwani <hmanwani@hmanwani.pnq.csb>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants