-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KieScanner behavior for already existing KieBases and KieSessions #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With reference to Drools-usage Google group discussion Ref. https://groups.google.com/d/topic/drools-usage/XpFlRNjuc9c/discussion Report below summary for reference. I think statement is missing to describe what happens to already existing KieSession and KieBase; from the current description I would have assumed only "new" stuff gets up-to-date, but (fortunately!) also some type of already-existing KieSession and KieBase gets automatically updated. Current behavior "From this moment on" proved by code actually is: 1- already existing KieBase, generated with getKieBase() : it does get automatically updated. This is the use case of named KieBase or default KieBase referenced from kmodule.xml 2- already existing KieBase, generated with newKieBase() : NOT automatically updated. This is the use case of KieBase created with "custom" KieBaseConfiguration settings and NOT referencing kmodule.xml 3- any KieBase generated after the KieScanner updated, with either getKieBase() or newKieBase() : directly the newer version, simple case, indeed as already mentioned in the documentation. Behavior for already existing KieSession depends on the underlying KieBase, so it make reference to the cases described here-above. To be fully explicit, when already existing KieSession was generated directly from KieContainer.newKieSession() is case #1 because it implies the default KieBase from kmodule.xml.
Can one of the admins verify this PR? Comment with 'ok to test' to start the build. |
@mariofusco could you please take a look? |
ChristyWatkins
pushed a commit
that referenced
this pull request
Oct 30, 2017
* BXMSDOC-1766 resolving merge conflicts * Merge pull request #21 from emmurphy1/BXMSDOC-1766-master Bxmsdoc 1766 master * BXMSDOC-1766 added case management to main.adoc to avoid MC
vidya-iyengar
pushed a commit
that referenced
this pull request
Sep 21, 2018
* most work done on both Rostering docs * more information on building etc * SME review * finishing SME revire * SME and QE review changes * peer review results * removed s2i
vidya-iyengar
pushed a commit
that referenced
this pull request
Sep 21, 2018
* most work done on both Rostering docs * more information on building etc * SME review * finishing SME revire * SME and QE review changes * peer review results * removed s2i
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With reference to Drools-usage Google group discussion Ref.
https://groups.google.com/d/topic/drools-usage/XpFlRNjuc9c/discussion
Report below summary for reference.
I think statement is missing to describe
what happens to already existing KieSession and KieBase; from the
current description I would have assumed only "new" stuff gets
up-to-date, but (fortunately!) also some type of already-existing
KieSession and KieBase gets automatically updated.
Current behavior "From this moment on" proved by code actually is:
1- already existing KieBase, generated with getKieBase() : it does get
automatically updated. This is the use case of named KieBase or default
KieBase referenced from kmodule.xml
2- already existing KieBase, generated with newKieBase() : NOT
automatically updated. This is the use case of KieBase created with
"custom" KieBaseConfiguration settings and NOT referencing kmodule.xml
3- any KieBase generated after the KieScanner updated, with either
getKieBase() or newKieBase() : directly the newer version, simple case,
indeed as already mentioned in the documentation.
Behavior for already existing KieSession depends on the underlying
KieBase, so it make reference to the cases described here-above.
To be fully explicit, when already existing KieSession was generated
directly from KieContainer.newKieSession() is case #1 because it implies
the default KieBase from kmodule.xml.