Bug 1250349 - Exceptions are not logged in server.log file if not abl…

…e to connect to kie-server (cherry picked from commit 25064d5)
kiegroup · Sep 2, 2015 · b222c25 · b222c25
1 parent b656896
commit b222c25
Showing 1 changed file with 34 additions and 23 deletions.
diff --git a/...g/kie/workbench/common/screens/server/management/backend/ServerManagementServiceImpl.java b/...g/kie/workbench/common/screens/server/management/backend/ServerManagementServiceImpl.java
@@ -28,12 +28,14 @@
 
 import org.guvnor.common.services.project.model.GAV;
 import org.jboss.errai.bus.server.annotations.Service;
+import org.kie.remote.common.rest.KieRemoteHttpRequestException;
 import org.kie.server.api.model.KieContainerResource;
 import org.kie.server.api.model.KieContainerStatus;
 import org.kie.server.api.model.KieScannerResource;
 import org.kie.server.api.model.KieScannerStatus;
 import org.kie.server.api.model.KieServerInfo;
 import org.kie.server.api.model.ReleaseId;
+import org.kie.server.client.KieServicesException;
 import org.kie.server.controller.api.KieServerControllerAdmin;
 import org.kie.server.controller.api.model.KieServerInstance;
 import org.kie.server.controller.api.model.KieServerInstanceInfo;
@@ -225,30 +227,39 @@ public void registerServer( final String endpoint,
         checkNotEmpty( "endpoint", endpoint );
         checkNotEmpty( "name", name );
 
-        final KieServerInfo kieServerInfo = new KieServerInfo();
-        kieServerInfo.setServerId(endpoint);
-        kieServerInfo.setName(name);
-        kieServerInfo.setVersion(version);
-
-        controllerAdmin.addKieServerInstance(kieServerInfo);
-
-        Server serverRef = new ServerImpl(
-                kieServerInfo.getServerId(),
-                "url",
-                kieServerInfo.getName(),
-                "user",
-                "password",
-                ContainerStatus.STOPPED,
-                ConnectionType.REMOTE,
-                null,
-                new HashMap<String, String>() {{
-                    put( "version", kieServerInfo.getVersion() );
-                }},
-                null
-        );
-
-        serverConnectedEvent.fire(new ServerConnected(serverRef));
+        try {
+
+            final KieServerInfo kieServerInfo = new KieServerInfo();
+            kieServerInfo.setServerId( endpoint );
+            kieServerInfo.setName( name );
+            kieServerInfo.setVersion( version );
+
+            controllerAdmin.addKieServerInstance( kieServerInfo );
+
+            Server serverRef = new ServerImpl(
+                    kieServerInfo.getServerId(),
+                    "url",
+                    kieServerInfo.getName(),
+                    "user",
+                    "password",
+                    ContainerStatus.STOPPED,
+                    ConnectionType.REMOTE,
+                    null,
+                    new HashMap<String, String>() {{
+                        put( "version", kieServerInfo.getVersion() );
+                    }},
+                    null
+            );
+
+            serverConnectedEvent.fire( new ServerConnected( serverRef ) );
 
+        } catch (KieServicesException e) {
+            logger.warn( "Connection failed", e );
+            throw e;
+        } catch (KieRemoteHttpRequestException e) {
+            logger.warn( "Connection failed", e );
+            throw e;
+        }
     }
 
     private KieContainerResource findContainerById(String containerId, Set<KieContainerResource> containerResources) {