PLANNER-284: Code style + performance #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
oskopek
commented
Aug 25, 2015
oskopek
commented
- Creating a new Map instead of clearing it is debatable, feel free to leave that commit out.
|
I 'll revert the clear() line indeed: if they do heavily use 20 different score levels for 1 match, then the Map capacity will have expanded to 20 already and remain that way after the clear(), improving later performance |
ge0ffrey
added a commit
that referenced
this pull request
Aug 26, 2015
PLANNER-284: Code style + performance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.