New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ktlint #11
Add ktlint #11
Conversation
I signed the CLA. |
amazing, thank you! |
I saw #5 and thought you might be switching to travis soon. But I'll update the circle ci config anyway. Re. spotless I'll wait and see what @digitalbuddha thinks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yarivkenan Thanks for the PR, would you mind splitting up "Add ktlint" and "Update dependencies" into separate PRs?
For the "Add ktlin" PR, can you update https://github.com/dropbox/Store/blob/master/CONTRIBUTING.md#coding-style to ask contributors apply Ktlint to either IntelliJ or githooks (i'm not sure which is better)
https://github.com/JLLeitschuh/ktlint-gradle#additional-helper-tasks
Thank you for the contribution! |
98772e1
to
502783f
Compare
Rebased with the following changes:
|
Do you mind doing the other diff you had as well? We can use some upgrades of dependencies :-) |
yep, hang on for a minute. |
Resolves #10
PR adds ktlint throught the ktlint-gradle plugin.
I've fixed all issues reported by the default rules (except
import-ordering
which is inconsistent with Android Studio). Let me know if you want any specific rules disabled.I also updated all dependencies in a separate commit and cleaned up unused ones.Update: I'll do this in a separate PR as suggested.
Tested with
./gradlew assemble check
.There are still a bunch of kotlin compiler warnings e.g. missing
@ExperimentalCoroutinesApi
annotations which I can address in a separate PR.