-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: Need support for includeBuild #100
Comments
Sounds interesting, How would we get the git data for the external build? We would need it to find which files are changed. |
Sample https://github.com/rougsig/AffectedModuleDetector/tree/main/sample I've add failing test to includeBuild to that file
In gradle dependencies to module in includeBuild realised like external dependency. More info can be found here. Expected behaviour is: Project structure is: Change in utils-module (in includeBuild). |
To find module from include build, we need to know group of that module. I can try to make PR with that logic, but it have one problem. We need to register group id and path of include build. |
Sorry for the delay here but can you explain what you mean by "We need to register group id and path of include build" @rougsig? Are you saying that we would need to have them manually state any included builds? I've played around with this a bit and it seems like the only way to get what included builds programmatically is to do |
I've implemented my own version of affected-module-detector with includeBuild support. Actually affected-module-detecktor should resolve dependencies, not iterate by them as now. |
Alright, then I will close this but feel free to put up a PR for you And thank you for the note on how to better handle dependencies |
More details about includeBuild here
Include build can be used as dependency, but for gradle that kind of dependency is external dependency.
ProjectGraph can't work correct with includeBuild dependencies. For ProjectGraph includeBuild dependencies is external dependencies, not project dependencies. In that case not all modules can be found, and marked as unknownFiles.
The text was updated successfully, but these errors were encountered: