Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support channelMax and frameMax negotiation #29

Closed
carlhoerberg opened this issue May 14, 2015 · 2 comments
Closed

Support channelMax and frameMax negotiation #29

carlhoerberg opened this issue May 14, 2015 · 2 comments

Comments

@carlhoerberg
Copy link

This library can't connect if the server has limited channelMax.
@barshow
Copy link
Contributor

barshow commented May 14, 2015

Ok I pushed a fix for this, it will no honor channel max and frame max BUT it doesn't enforce and channel limits from the client. Im not sure what the correct if you try to do something when the channel limit is reached. Do you error immediately or wait and queue things up? I think i'm leaning towards just error quickly.

you can test it with amqp-coffee@0.1.22-rc2

heres the commit : bfc9fd1

@carlhoerberg
Copy link
Author

Thanks!

@barshow barshow closed this as completed Jun 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@carlhoerberg @barshow