New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: for multiplatform deps, only include target platform #56
Comments
In this situation, isn't the case that My general thought on dependency guard was to gain insight on everything that you are shipping to customers. If I understand correctly, that's here as well.
|
I'll double check but I don't believe it is, otherwise we'd have duplicate class issues with androidx's compose runtime |
And yes I'd expect only things from Android main effectively |
🤔 - Okay, that seems like a valid usage option of this. How does I'm seeing how the feature you are describing could be useful to a team to just see what is there for How would we compute this?
I would then think we'd do an intersection where you'd take everything in Something like that? |
☝️ I included a list of configurations that could be depended on. In the example above, you would probably only need the The intersection result is I think what you'd be looking for here? |
I looked a little more closely at it and I think this is actually "correct" by the letter of the gradle law. There is an android compose-jb artifact, but it's just a shim pointing at the real androidx compose dep
|
If a kotlin multiplatform lib is depended on and has, say,
org.jetbrains.compose:runtime
as acommon
dependency, it gets included in an android dependency guard classpath even though there is no android platform exposed for that dep.The text was updated successfully, but these errors were encountered: