Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Won't build with the latest Nightly #19

Closed
Yoric opened this issue May 18, 2018 · 4 comments
Closed

Won't build with the latest Nightly #19

Yoric opened this issue May 18, 2018 · 4 comments

Comments

@Yoric
Copy link
Contributor

Yoric commented May 18, 2018

I get a bunch of errors such as:

^^^^^^^^^^^^^ slice indices are of type usizeor ranges ofusize``

See for instance https://travis-ci.org/binast/binjs-ref/jobs/380663418#L725 .

@Yoric
Copy link
Contributor Author

Yoric commented May 18, 2018

Ah, I see that it's already being fixed. Thanks :)

Are you planning a new release soon?

@dekellum
Copy link

Not fixed as of:

rustc 1.28.0-nightly (a1d4a9503 2018-05-20)

Example failure:

https://travis-ci.org/dekellum/body-image/jobs/380453803#L299

@dekellum
Copy link

The issue is also tracked for rustc, with other effected crates, in rust-lang/rust#50825.

Above I was seeing this issue with brotli 1.2.0, but an upgrade (dekellum/body-image@2741bbc4) to brotli 2.2.1 (released May 20) fixes the issue for me, presumably because of ae6d9d2.

Some brief release notes or at least release tags for the brotli crate, could help users to help themselves for bugs like this. I'm also wondering what else has changed in the major 2.x release series.

@danielrh
Copy link
Collaborator

danielrh commented Jun 5, 2018

This is fixed in 2.3 which also contains a fix for flush()

@danielrh danielrh closed this as completed Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants