Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql-alchemy 1.4 - using is_not on column leads to mypy warning, while using isnot does not lead to the warning #244

Open
serhiy-yevtushenko opened this issue Jun 24, 2022 · 1 comment

Comments

@serhiy-yevtushenko
Copy link

serhiy-yevtushenko commented Jun 24, 2022

In the sqlalchemy version 1.4, the method isnot was renamed to is_not, and the old method was left for backward compatibility.

(see https://docs.sqlalchemy.org/en/14/core/sqlelement.html#sqlalchemy.sql.expression.ColumnOperators.is_not)

However, if one try to use is_not on the column expression

(something like:

...
.where(and_(pch_alias.c.New_Id.is_not(None))))

)
then one gets following warning in mypy:

error: "Column[Any]" has no attribute "is_not"
However, if one is using older isnot construct, then mypy produces no warning.

As is_not now is a recommended method, I think stubs should function with it without warnings.

@philbudne
Copy link

Ihttps://github.com//issues/237 covers this, and more cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants