Add dynamic framework target #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The zxcvbn Xcode project and /Zxcvbn folder now only contain the primary source files, the example project source has been moved into /Example. The project should continue to be usable by source / CocoaPods (though someone should verify the podfile tweaks are accurate) but now also offers a dynamic framework (iOS 8+) for easy integration via Carthage. In addition to file moving, two small fixes were made: - The JSON resources are fetched from the bundle by class rather than main bundle - A couple of imports were missing that were previously provided via precompiled header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for the rather large diff but there isn't much middle ground. The project should continue to be usable by source / CocoaPods (though someone should verify the podfile tweaks are accurate) but now also offers a dynamic framework (iOS 8+) for easy integration via Carthage. The PR reorganizes the files a bit and makes a couple fixes.
Zxcvbn.xcodeprojand/Zxcvbnnow only contain the primary source files and the example project has been moved toiOS Example.xcodepojand/Example.In addition to file moving, two small fixes were made: