New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
It gets very slow for some password lengths #7
Comments
This happens because DBMatcher's are being allocated multiple times which is loading the frequency lists using lots of memory. If you put the frequency list initialization in a singleton it stops the memory leak and makes performance good again |
This is not the case. |
In the spacialEntropy call in DBScorer the allocate method is called again. I believe this method is only called on long passwords and thats why the slowdown only happens on longer passwords |
IF |
Thats what I did to fix it I wrapped the initialization of the frequency lists and adjacency graphs in a singleton object so they are only ever created once and it sped up the performance significantly |
@jessemx109 want to submit a pull request with that change? That would be really nice 😄 |
👍 would appreciate that performance boost |
I think this was done in #8? Closing this issue but feel free to re-open if there's more we can do to improve this. |
For password
testScorePassword123
it takes 0.5 sec to compute the score, which is A LOT!It looks like there is some high complexity algorithm, cause time grows exponentially after some length.
The text was updated successfully, but these errors were encountered: