Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reset() to Reservoir API #399

Closed
ryantxu opened this issue May 15, 2013 · 1 comment
Closed

Add reset() to Reservoir API #399

ryantxu opened this issue May 15, 2013 · 1 comment

Comments

@ryantxu
Copy link

ryantxu commented May 15, 2013

It would be nice to be able to reset the metrics counter.

I think the the most approprate way is to add a 'reset()' function on the Reservoir API.

If this seems like a reasonable direction, I will put together a pull request

Thanks
Ryan

@codahale
Copy link
Contributor

This is a common request, and one I keep turning down. Resettable metrics mean a whole other layer of mutability which ends up producing a lot of weird edge cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants