Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

destroy should remove instance from Dropzone.instances #401

Closed
stephennancekivell opened this issue Dec 2, 2013 · 2 comments
Closed

destroy should remove instance from Dropzone.instances #401

stephennancekivell opened this issue Dec 2, 2013 · 2 comments
Assignees
Labels
bug Bug in the library priority Should be fixed ASAP

Comments

@stephennancekivell
Copy link

Dropzone leaks memory by always adding a reference to Dropzone.instances and never removing them.

I have an angular.js project where we create dropzones without reloading the page.

Im able to stop the memory leak by manually removing the reference from Dropzone.instances like ..

Dropzone.instances = _.without(Dropzone.instances, myDropzone);
@enyo
Copy link
Collaborator

enyo commented Dec 5, 2013

Completely right! I have to go over the whole destroy process anyway and make sure that it behaves properly.

@ghost ghost assigned enyo Dec 5, 2013
@stephennancekivell
Copy link
Author

Cool. Thanks for the sweet library btw.

@enyo enyo closed this as completed in 797bae6 Dec 7, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug in the library priority Should be fixed ASAP
Projects
None yet
Development

No branches or pull requests

2 participants