Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New functions in v5.0.2 not externed with GB_PUBLIC #40

Closed
eriknw opened this issue May 5, 2021 · 5 comments
Closed

New functions in v5.0.2 not externed with GB_PUBLIC #40

eriknw opened this issue May 5, 2021 · 5 comments

Comments

@eriknw
Copy link
Contributor

eriknw commented May 5, 2021

GxB_Matrix_concat, GxB_Matrix_diag, GxB_Matrix_split, GxB_Vector_diag were not externed with GB_PUBLIC. I suspect this was a simple oversight. Sorry for not checking this earlier!
@DrTimothyAldenDavis
Copy link
Owner

Oops... yes, that's an oversight. I'll fix it and it will be in 5.0.3.

@eriknw
Copy link
Contributor Author

eriknw commented May 5, 2021

Sounds good. Do you have an ETA for 5.0.3?

Once we get better automated testing and building for python-suitesparse-graphblas, we should catch errors like this before you release.

@DrTimothyAldenDavis
Copy link
Owner

I just posted this fix in the master branch with the latest commit. I could wait a few days to collect any more current issues.

@eriknw
Copy link
Contributor Author

eriknw commented May 5, 2021

Cool, and no rush. I was just curious :)

@DrTimothyAldenDavis
Copy link
Owner

Just posted v5.0.3 with this fix, and a few others. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eriknw @DrTimothyAldenDavis