Skip to content

Commit

Permalink
Remove 1.8 NMS spawner providers (#3276)
Browse files Browse the repository at this point in the history
This PR removes the 1.8 R1 and R2 spawner providers. I was looking into refactoring these to use reflection instead of importing NMS code (in order to avoid requiring buildtools to compile), but after some research it looks like these are actually not even used anymore, in favor of the LegacySpawnerProvider (which Essentials appears to use for 1.8.0-1.12.2). Thus, keeping these is fairly pointless and causes more harm than good. There is no reason to continue including them, nor maintaining them. Essentials currently doesn't even officially support these versions anyway.
  • Loading branch information
pop4959 committed May 13, 2020
1 parent d59fd71 commit e53520a
Show file tree
Hide file tree
Showing 8 changed files with 0 additions and 156 deletions.
4 changes: 0 additions & 4 deletions Essentials/src/com/earth2me/essentials/Essentials.java
Expand Up @@ -48,8 +48,6 @@
import net.ess3.nms.refl.ReflSpawnEggProvider;
import net.ess3.nms.updatedmeta.BasePotionDataProvider;
import net.ess3.nms.updatedmeta.BlockMetaSpawnerProvider;
import net.ess3.nms.v1_8_R1.v1_8_R1SpawnerProvider;
import net.ess3.nms.v1_8_R2.v1_8_R2SpawnerProvider;
import net.ess3.providers.ProviderFactory;
import org.bukkit.Bukkit;
import org.bukkit.Server;
Expand Down Expand Up @@ -251,8 +249,6 @@ public void onEnable() {
spawnerProvider = new ProviderFactory<>(getLogger(),
Arrays.asList(
BlockMetaSpawnerProvider.class,
v1_8_R2SpawnerProvider.class,
v1_8_R1SpawnerProvider.class,
LegacySpawnerProvider.class
), "mob spawner").getProvider();
spawnEggProvider = new ProviderFactory<>(getLogger(),
Expand Down
1 change: 0 additions & 1 deletion nms/1_8_R1Provider/.gitignore

This file was deleted.

28 changes: 0 additions & 28 deletions nms/1_8_R1Provider/pom.xml

This file was deleted.

This file was deleted.

1 change: 0 additions & 1 deletion nms/1_8_R2Provider/.gitignore

This file was deleted.

28 changes: 0 additions & 28 deletions nms/1_8_R2Provider/pom.xml

This file was deleted.

This file was deleted.

2 changes: 0 additions & 2 deletions pom.xml
Expand Up @@ -51,8 +51,6 @@
<module>EssentialsXMPP</module>
<module>nms/NMSProvider</module>
<module>nms/UpdatedMetaProvider</module>
<module>nms/1_8_R1Provider</module>
<module>nms/1_8_R2Provider</module>
<module>nms/LegacyProvider</module>
<module>nms/ReflectionProvider</module>
<module>nms/FlattenedProvider</module>
Expand Down

0 comments on commit e53520a

Please sign in to comment.