Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Official generic gitpod support #3283

Closed
rfay opened this issue Oct 1, 2021 · 15 comments
Closed

Official generic gitpod support #3283

rfay opened this issue Oct 1, 2021 · 15 comments
Milestone

Comments

@rfay
Copy link
Member

rfay commented Oct 1, 2021

@shaal has done wonders with DrupalPod and ddev-gitpod... but we need a generic DDEV environment for GitPod and GitHub Codespaces, and it shouldn't be that hard to do. This will help loads of people.

@rfay rfay added this to the v1.19 milestone Oct 1, 2021
@shaal
Copy link
Collaborator

shaal commented Oct 1, 2021

I'd love to hear more!

(and help with anything I can of course)

@rfay rfay changed the title Official generic gitpod support Official generic gitpod and GitHub Codespaces support Oct 1, 2021
@Decipher
Copy link

Decipher commented Oct 15, 2021

A CloudeIDE step for the ddev wizard that gives you choice based on existing configuration would be great.

@Decipher
Copy link

It'd also be nice to have the ability to do some configuration during setup, such as the port numbers, etc.

@rfay
Copy link
Member Author

rfay commented Oct 17, 2021

Can you be more specific about what you're talking about @Decipher ?

@Decipher
Copy link

When you first run the ddev config command you are provided with 3 questions which determined the configuration for your codebase.

At the least, I would like to see a CloudIDE option added to these steps which allowed you to choose: None, Gitpod, GitHub workspaces. Ideally it could determine the default answer based of available environment variables.

DDev would maintain some template configuration to enable the CloudIDE specific changes, such as the docker-compose.host-docker-internal.yaml file that DrupalPod creates: https://github.com/shaal/DrupalPod/blob/main/.gitpod/ddev-in-gitpod-setup.sh#L38-L47

It would also be nice to have an advanced configuration option that allows you to choose the ports for specific services and other types of config, such as being able to set bind_all_interfaces to TRUE.

@rfay
Copy link
Member Author

rfay commented Oct 17, 2021

Thanks -

  • I would expect it to always bind_all_interfaces and turn off ddev-router in the case of GitPod.
  • host.docker.internal is not in our control and so it's found dynamically by DrupalPod/ddev-gitpod. There may be a way to work around this now that docker 20.10 is available.

@shaal
Copy link
Collaborator

shaal commented Nov 9, 2021

I think the above comment is already resolved with ddev + gitpod recent changes, is that correct?

@rfay
Copy link
Member Author

rfay commented Nov 9, 2021

We can give it a shot! Not sure about the host.docker.internal issue, which is different from the need to bind_all_interfaces

@shaal
Copy link
Collaborator

shaal commented Nov 19, 2021

When trying to run ddev launch inside Gitpod workspace, the following error is displayed:

/workspace/DrupalPod/.ddev/commands/host/launch: line 61: xdg-open: command not found
Failed to run launch ; error=exit status 127

I think we should add that to this feature (+ #3371 ), so when running ddev launch inside a Gitpod workspace, it should not try open the browser directly. Instead, ddev can utilize Gitpod's own command - gp preview 8080

@shaal
Copy link
Collaborator

shaal commented Nov 19, 2021

@rfay wouldn't it be better to split this into 2 separate PRs?

  1. Launch a gitpod instance for any project (on github or gitlab) with a special URL
  2. Add ddev flag for gitpod configuration (without adding any external config files like we currently have to create)

To me, the ddev Gitpod flag feature is the most urgent.
Please let me know how I can help.

@rfay
Copy link
Member Author

rfay commented Nov 19, 2021

Well, far more than 2 PRs :) #3371 is exploring this territory, but what we'll actually need for your first item is a separate repository that's used for launching (drud/ddev isn't the right one) and a website that will help generate the special URL.

Please open an issue for your second item, explain what you're looking for and how you want to use it, thanks!

@rfay rfay changed the title Official generic gitpod and GitHub Codespaces support Official generic gitpod support Nov 19, 2021
rfay added a commit that referenced this issue Dec 7, 2021
Co-authored-by: Ofer Shaal <ofer@3paces.com>
@rfay
Copy link
Member Author

rfay commented Dec 8, 2021

Official gitpod support begins with today's v1.18.2 release, along with https://github.com/drud/ddev-gitpod-launcher and the ddev chrome extension.

@rfay rfay closed this as completed Dec 8, 2021
@weitzman
Copy link
Contributor

weitzman commented Dec 8, 2021 via email

@rfay
Copy link
Member Author

rfay commented Dec 8, 2021

Look for ddev in chrome web store, install it. It has a ways to go, but it just creates a button like the gitpod chrome extension, which will open a repo using ddev-gitpod-launcher.

@rfay
Copy link
Member Author

rfay commented Dec 8, 2021

Docs in #3434 @weitzman - would love to have your review.

rfay added a commit that referenced this issue Dec 8, 2021
…ixes #3406 (#3434)

* TestShareCmd should report ngrok error
* Improve PhpStorm instructions, fixes #3401
* Document gitpod usage for #3283
* Add details to phpstorm.md, fixes #3406
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants