Make large uid users run successfully on macOS, fixes #1281 #1285
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem/Issue/Bug:
A regression in v1.4.0 meant that macOS users (and Linux users, though less likely) with UIDs above 60000 couldn't run ddev successfully (sudo failed, see OP #1281 )
How this PR Solves The Problem:
The basically reverts back to the original behavior, automatically using a uid of 1000 if the UID is above 60000. Otherwise it just tries to use the normal user uid. This is fairly safe on macOS and Windows. It's highly questionable on Linux, where an inappropriate uid can create privileged files.
Manual Testing Instructions:
ddev ssh
andid
). The uid and gid should be the same as your macOS uid/gid.ddev ssh
. andid
. You should see uid_1000Automated Testing Overview:
Related Issue Link(s):
Release/Deployment notes: