Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gotestsum for test output on circleci #1306

Merged
merged 8 commits into from Nov 30, 2018
Merged

Conversation

rfay
Copy link
Member

@rfay rfay commented Nov 26, 2018

The Problem/Issue/Bug:

gotestsum looks like a promising formatter for test output.
https://circleci.com/blog/level-up-go-test-with-gotestsum/
https://github.com/gotestyourself/gotestsum

How this PR Solves The Problem:

Manual Testing Instructions:

Automated Testing Overview:

Related Issue Link(s):

Release/Deployment notes:

@rfay rfay self-assigned this Nov 26, 2018
@@ -42,6 +44,8 @@ jobs:
command: make -s test
name: ddev tests
no_output_timeout: "40m"
- store_test_results:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to point to the full path of where the gotestsum command placing the XML. Or we can add a step after make test to mv/cp the file over

@rfay
Copy link
Member Author

rfay commented Nov 26, 2018

Well, this is pretty. (https://circleci.com/gh/drud/ddev/6487?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-checks-link). But I'm not sure what it did with the uploaded test results, or why it matters.

@rfay rfay merged commit d965c64 into ddev:master Nov 30, 2018
@rfay rfay deleted the 20181126_gotestum branch November 30, 2018 00:25
@rfay
Copy link
Member Author

rfay commented Nov 30, 2018

OK, let's try this out. @andrewfrench seemed to like the format. We'll just pull it out if we don't like it.

One thing I did here that might result in issues is just increasing the test timeout quite a lot, and I notice we actually do have a hanging test (TestCaptureLogs) on Apache. So that one will pain us when it uses up a whole 2 hours. Could be a mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants