New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use gotestsum for test output on circleci #1306
Conversation
@@ -42,6 +44,8 @@ jobs: | |||
command: make -s test | |||
name: ddev tests | |||
no_output_timeout: "40m" | |||
- store_test_results: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to point to the full path of where the gotestsum command placing the XML. Or we can add a step after make test to mv/cp the file over
Well, this is pretty. (https://circleci.com/gh/drud/ddev/6487?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-checks-link). But I'm not sure what it did with the uploaded test results, or why it matters. |
cea8044
to
eb6995e
Compare
OK, let's try this out. @andrewfrench seemed to like the format. We'll just pull it out if we don't like it. One thing I did here that might result in issues is just increasing the test timeout quite a lot, and I notice we actually do have a hanging test (TestCaptureLogs) on Apache. So that one will pain us when it uses up a whole 2 hours. Could be a mistake. |
The Problem/Issue/Bug:
gotestsum looks like a promising formatter for test output.
https://circleci.com/blog/level-up-go-test-with-gotestsum/
https://github.com/gotestyourself/gotestsum
How this PR Solves The Problem:
Manual Testing Instructions:
Automated Testing Overview:
Related Issue Link(s):
Release/Deployment notes: