Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working sample elasticsearch as additional service #1319 #1320

Conversation

thursdaybw
Copy link

The Problem/Issue/Bug:

Resolves #1319
Provides a sample docker composer file for elasticsearch

How this PR Solves The Problem:

Provides the sample file.

Manual Testing Instructions:

Download this file to your ddev's .ddev folder and do ddev start

Automated Testing Overview:

It's a sample config, no tests.

Related Issue Link(s):

#1319

Notes

I'm pretty sure this isn't the right location for this file as the SOLR and Memcached samples appear to be used as test data for a test.
Please advice if there's a better location to host this example?

@CLAassistant
Copy link

CLAassistant commented Dec 5, 2018

CLA assistant check
All committers have signed the CLA.

@rfay rfay changed the title Working sample elasticserch as additional service #1319 Working sample elasticsearch as additional service #1319 Dec 11, 2018
@rfay rfay force-pushed the 1319-working-elasticsearch-addtional-service-config branch from fa213e8 to 1be778b Compare January 7, 2019 22:40
@rfay
Copy link
Member

rfay commented Jan 7, 2019

I rebased this and brought it up, but there are no manual testing instructions to determine if elasticsearch is doing something we want it to do. Could you please edit the OP to provide manual testing instructions?

@mkrauser
Copy link

I can't wait to use this... thanks for your work!

@rfay
Copy link
Member

rfay commented Jan 31, 2019

@mkrauser your review on this would help get it pulled. How does it work for you? Let me know if you need help knowing how to get it or whatever.

@rfay rfay force-pushed the 1319-working-elasticsearch-addtional-service-config branch from 1be778b to b33f924 Compare January 31, 2019 17:39
@rfay
Copy link
Member

rfay commented Jan 31, 2019

Rebased to current upstream/master.

@mkrauser
Copy link

@rfay Disclaimer: I just started using ddev some weeks ago and I'm not a pro with elastic-search (but we will need that for a project really soon)

I gave it a shot on MacOS 10.14.2:
Adding ElasticSearch to the project worked like expected, just copy the docker-compose-file to .ddev and fire it up. ES is then reachable from the web-container and from the host. I put some sample-data in ES (downloaded from https://www.elastic.co/guide/en/kibana/current/tutorial-load-dataset.html) and started a local kibana installation.
Everything worked as expected, no crashes or issues of any kind.

One Question: Is the ES-Config adjustable like for the webservers? Since ES can be configured in so many ways, this would be really good to have this option.

And I would really love to see a Kibana-Installation bundled here. But that's in no way a show-stopper for this.

@thursdaybw Good work! Thanks again

@rfay
Copy link
Member

rfay commented Jan 31, 2019

Thanks so much for taking that for a spin.
The config basically in your hands; I think if I wanted extra config, I'd want to add a bind-mount that mounted that config, and there's none in this example.

@rfay rfay force-pushed the 1319-working-elasticsearch-addtional-service-config branch from b33f924 to 3845118 Compare February 6, 2019 04:25
@rfay rfay force-pushed the 1319-working-elasticsearch-addtional-service-config branch from 3845118 to 6e009ad Compare February 7, 2019 02:51
@rfay
Copy link
Member

rfay commented Feb 7, 2019

We were never able to get a community review on this, or a response from @thursdaybw so moved this to Stack Overflow at https://stackoverflow.com/questions/54575785/how-can-i-use-an-elasticsearch-add-on-container-service-with-ddev/54575786#54575786 - hopefully it can incubate there.

Thanks for the contribution @thursdaybw and I hope it's working for you and look forward to more of these, and hope you'll "watch" the SO article and help people there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants