Bring in build_tools 2.0 #1371
Merged
Bring in build_tools 2.0 #1371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfay
force-pushed
the
20190108_bring_in_build_tools
branch
2 times, most recently
from
4055263
to
1ff92ed
Compare
andrewfrench
approved these changes
Jan 10, 2019
rfay
force-pushed
the
20190108_bring_in_build_tools
branch
from
44175b7
to
c87c1e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem/Issue/Bug:
This does these things:
go mod vendor. I wasn't able to build without doing this, but you'll note that go.sum didn't change, so it should have no effect. (go mod vendor does leave out a number of non-code files)This can be brought in after the build-tools release is done and we should update here at that time.
How this PR Solves The Problem:
Manual Testing Instructions:
Automated Testing Overview:
Related Issue Link(s):
Release/Deployment notes: