Don't ask about sentry if DDEV_NO_SENTRY #1392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewfrench
approved these changes
Jan 21, 2019
cmd/ddev/cmd/root.go
Outdated
| @@ -151,7 +151,7 @@ func sentryNotSetupWarning() { | |||
| // from the last saved version. If it is, prompt to request anon ddev usage stats | |||
| // and update the info. | |||
| func checkDdevVersionAndOptInSentry() error { | |||
| if !output.JSONOutput && version.COMMIT != globalconfig.DdevGlobalConfig.LastUsedVersion && globalconfig.DdevGlobalConfig.InstrumentationOptIn == false { | |||
| if !output.JSONOutput && version.COMMIT != globalconfig.DdevGlobalConfig.LastUsedVersion && globalconfig.DdevGlobalConfig.InstrumentationOptIn == false && os.Getenv("DDEV_NO_SENTRY") == "" { | |||
There was a problem hiding this comment.
I think it'd be a good idea to define the environment variable name as a constant in values.go because it's hard-coded in several places, but that's a small point.
rfay
force-pushed
the
20190120_dont_ask_beam_up_if_ddev_no_sentry
branch
from
406d8e5
to
021d9f9
Compare
|
Good idea @andrewfrench - please see how this looks. |
andrewfrench
approved these changes
Jan 21, 2019
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem/Issue/Bug:
It's just annoying to be asked about sentry when you're developing and you do a new build. No reason to ask if DDEV_NO_SENTRY.
How this PR Solves The Problem:
Manual Testing Instructions:
Automated Testing Overview:
Related Issue Link(s):
Release/Deployment notes: