Add separate lines for each external_links, fixes #1235 #1546
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem/Issue/Bug:
OP #1235: With a single hostname (the default situation, like "somesite.ddev.local", the name was resolved from within the web container as being the ddev-router.
However, as soon as you added additional_hostnames or additional_fqdns, this feature disappeared
How this PR Solves The Problem:
The docker-compose.yaml was being incorrectly generated. A separate entry in external_links: was required for each of those entries.
Manual Testing Instructions:
ddev ssh
curl http://hostname1.ddev.local
successfully (it should be going to ddev-router)ping hostname1.ddev.local
actually resolves to ddev-router's IP address.Automated Testing Overview:
TestInternalAndExternalAccessToURL() was updated to do lots of hits both inside and outside.
Related Issue Link(s):
OP #1235
Release/Deployment notes:
03d065b fixes a bug where ComposeWithStreams() did not return the error it encountered, which caused app.Exec() to misbehave. It's possible this will affect some other behavior.