Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add separate lines for each external_links, fixes #1235 #1546

Merged
merged 6 commits into from Apr 26, 2019

Conversation

rfay
Copy link
Member

@rfay rfay commented Apr 23, 2019

The Problem/Issue/Bug:

OP #1235: With a single hostname (the default situation, like "somesite.ddev.local", the name was resolved from within the web container as being the ddev-router.

However, as soon as you added additional_hostnames or additional_fqdns, this feature disappeared

How this PR Solves The Problem:

The docker-compose.yaml was being incorrectly generated. A separate entry in external_links: was required for each of those entries.

Manual Testing Instructions:

  • Create a project with additional_hostnames and additional_fqdns.
  • ddev ssh
  • You should be able to curl http://hostname1.ddev.local successfully (it should be going to ddev-router)
  • Verify that ping hostname1.ddev.local actually resolves to ddev-router's IP address.

Automated Testing Overview:

TestInternalAndExternalAccessToURL() was updated to do lots of hits both inside and outside.

Related Issue Link(s):

OP #1235

Release/Deployment notes:

03d065b fixes a bug where ComposeWithStreams() did not return the error it encountered, which caused app.Exec() to misbehave. It's possible this will affect some other behavior.

@rfay rfay added this to the v1.8.0 milestone Apr 23, 2019
@rfay rfay self-assigned this Apr 23, 2019
@rfay rfay force-pushed the 20190423_additional_hostnames_links branch from 4c49a07 to 96d97e9 Compare April 24, 2019 20:16
Copy link
Contributor

@andrewfrench andrewfrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with the following configuration and test:

  • update additional_hostnames to include myhostname
  • update additional_fqdns to include myhostname.com
  • ddev start
  • ddev ssh
  • curl myhostname.ddev.local => index.php response
  • curl myhostname.com => index.php response
  • ping myhostname.ddev.local => resolves and receives response
  • pint myhostname.com => resolves and receives response

@rfay rfay merged commit 5940cdb into ddev:master Apr 26, 2019
@rfay rfay deleted the 20190423_additional_hostnames_links branch April 26, 2019 01:46
@rfay rfay mentioned this pull request May 9, 2019
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants