-
-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support zsh, fish, and Powershell autocompletion, fixes #327 #2234
Conversation
This zipfile contains _ddev, the zsh autocomplete file. To test, please unzip it into your local $fpath, then |
Autocompletions for fish, zsh, bash, and PowerShell are in this zipfile: |
Maybe it's the best to do it like in Kubernetes? In short: Instead of generating the files in CI and copy them around and dealing with differences in OS and Linux Distro placing, K8S provides a This way for bash you do: For Zsh: |
That's what we actually do for generation; we have a separate executable (in this PR) that generates the completions. It actually uses the same generating code that kubectl does. The problem here is that you can't just add completions to bashrc or .zshrc, that's not where they belong. They're huge, and it would make an enormous mess of .bashrc or .zshrc. And I don't even understand why they suggest changing anything in .bashrc, since it should already be set up on macOS (and usually on Linux) to source the correct directory. Also, if you read closely in the kubectl instructions, you'll see that they require that you install bash 4, which of course changes the behavior of many things on macOS and would be unacceptable. Anyway, it's a morass :) But we'll get through it. |
7eef783
to
c107bc4
Compare
The Problem/Issue/Bug:
#327 requests zsh autocomplete.
How this PR Solves The Problem:
/usr/local/share/zsh/site-functions
Manual Testing Instructions:
Automated Testing Overview:
Related Issue Link(s):
Release/Deployment notes: