Make ssh-auth volume name explicit on creation, fixes #3075 #3077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rfay
force-pushed
the
20210629_chase_ssh_agent_problem
branch
from
7d96598
to
fc32690
Compare
This was referenced Jul 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem/Issue/Bug:
ddev auth sshdidn't work with docker-compose v2, see #3075How this PR Solves The Problem:
The problem turns out to be that docker-compose v2 uses a different default name for the volume
Manual Testing Instructions:
Normal testing for
ddev auth sshddev auth sshand add some keysddev exec ssh-add -lshould show your keys