Compatibility with docker-compose v1, fixes #3649 #3657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem/Issue/Bug:
ddev 1.19.0-rc1: docker-compose v1 usage fails due to use of
docker-compose convert#3649The new ddev v1.19 was using
docker-compose convert, which was listed as an alias ofdocker-compose config, but in reality,docker-compose convertis not valid in docker-compose v1.I also noted that docker-compose v1 doesn't create a "name" for a volume, so volumes wouldn't be deleted if they don't have an explicit name. Rather than trying to work around that I just added a name in ddev-drupal9-solr, ddev/ddev-drupal-solr@d00c4ac
Manual Testing Instructions:
Automated Testing Overview:
Added TestComposeV1