Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apo targets not getting pocket center correctly defined #151

Closed
j-wags opened this issue Jun 29, 2017 · 4 comments
Closed

Apo targets not getting pocket center correctly defined #151

j-wags opened this issue Jun 29, 2017 · 4 comments
Labels
Milestone

Comments

@j-wags
Copy link
Contributor

j-wags commented Jun 29, 2017

From email: We also want to report a potential problem regarding apo structures that CELPP provided. For a few targets in recent weeks, apo structures were not mapped to other protein structures (e.g. LMCSS). In these cases, predictions would be failed if the binding site information in the file "center.txt" was used for docking. The following are a list of problem targets that we found. Hope these are helpful.

week22: 5lzj, 5lzg (celpp 1.8.0)

week 23: 5vt4, 5x8s (celpp 1.8.0)

week 24: 5suk (celpp 1.8.0)

week26: 5val, 5vam, 5vyj, 5xai (celpp 1.9.0)

@j-wags
Copy link
Contributor Author

j-wags commented Jun 29, 2017

My first suspicion is that we are somehow forgetting to do an alignment for the apo candidate. This timeline suggests that perhaps the change was when we started doing binding site alignments, which would fail for apo as it doesn't have a ligand to define a binding site.

@j-wags
Copy link
Contributor Author

j-wags commented Jul 3, 2017

Fixed by commit bf15a43 to master (not tagged/deployed)

@j-wags j-wags closed this as completed Jul 3, 2017
@j-wags j-wags reopened this Jul 3, 2017
@coleslaw481 coleslaw481 added the bug label Aug 3, 2017
@coleslaw481 coleslaw481 added this to the 1.9.1 milestone Aug 3, 2017
@j-wags
Copy link
Contributor Author

j-wags commented Aug 3, 2017

Pushed to staging. Need to ensure that this works correctly when CELPP runs week 32.

@j-wags
Copy link
Contributor Author

j-wags commented Aug 7, 2017

I've checked the week 32 challenge package for cases where this failure occurred on the celpp1 server. These failures are:
5gqe
5myg
5vyg (this is a really strange case)

On celpp-stage, 5gqe and 5myg are fixed. Therefore I think this bug is fixed and the code can be pushed to production.

5vyg is a different case and I'll open up an issue ticket for it.

@j-wags j-wags closed this as completed Aug 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants