Add flush prior to close on output stream in QueryResource #1441
Conversation
| @@ -183,6 +183,7 @@ public void write(OutputStream outputStream) throws IOException, WebApplicationE | |||
| { | |||
| // json serializer will always close the yielder | |||
| jsonWriter.writeValue(outputStream, yielder); | |||
| outputStream.flush(); // Some types of OutputStream suppress flush errors in the .close() method. | |||
There was a problem hiding this comment.
do we have some context in which case we see errors getting swallowed or is this purely defensive?
There was a problem hiding this comment.
Purely defensive.
There was a problem hiding this comment.
just curious, if there is no evidence then why are we fixing it now?
Usual usage pattern of OutputStream I have seen is to just rely on close call unless the usecase really demanded intermediate flushes while you write data and then write more after the flush and so on.
There was a problem hiding this comment.
Ok, I typed this comment way too fast, let me try again:
Close for many types of output streams will swallow exceptions in flush, leading to a "successful" close when there was really an exception during the final flush.
|
👍 |
Add flush prior to close on output stream in QueryResource
No description provided.