fix histogram aggregator cache key #1534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| .allocate(1 + fieldNameBytes.length + Floats.BYTES * breaks.length) | ||
| .put(CACHE_TYPE_ID) | ||
| .put(fieldNameBytes) | ||
| .put((byte)0); |
There was a problem hiding this comment.
to make sure there is a separator, otherwise it is possible to have fieldNames / breaks combinations that cause cache key collisions.
There was a problem hiding this comment.
We solved that in another cache key with invalid UTF-8 byte sequences I think. Can we do that here also?
xvrl
force-pushed
the
fix-histogram-cachekey
branch
from
bd66904
to
a15a2c4
Compare
drcrallen
added a commit
that referenced
this pull request
Jul 16, 2015
fix histogram aggregator cache key
seoeun25
pushed a commit
to seoeun25/incubator-druid
that referenced
this pull request
Jan 10, 2020
…ect-after-semijoin)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.