add endpoint to fetch rule history for all datasources #1542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -54,4 +54,12 @@ | |||
| */ | |||
| public List<AuditEntry> fetchAuditHistory(String key, String type, Interval interval); | |||
|
|
|||
| /** | |||
| * provides audit history for given type and interval | |||
| * @param type | |||
nishantmonu51
force-pushed
the
audit-rule-history
branch
2 times, most recently
from
7718480
to
6deee06
Compare
|
@xvrl @fjy @drcrallen @himanshug, This an addition of a simple end-point and does not impact any existing features, It will be good to have in 0.8.1. |
|
LGTM and I am OK adding it to 0.8.1 |
|
@nishantmonu51 Can we get this merge-able with master and I will merge it |
nishantmonu51
force-pushed
the
audit-rule-history
branch
from
6deee06
to
b3064fc
Compare
review comments Review comment fix compilation
nishantmonu51
force-pushed
the
audit-rule-history
branch
from
b3064fc
to
0835e12
Compare
|
👍 |
drcrallen
added a commit
that referenced
this pull request
Sep 1, 2015
add endpoint to fetch rule history for all datasources
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add http endpoint to fetch audit history for all datasources, helpful in getting a consolidated view of rule changes.