print *all* HTTP requests to log if configured

[himanshug]

I understand that there is, druid.request.logging.type, which does not look general enough to print all http requests received by server but mainly targeted towards printing query requests.

[drcrallen]

would it make sense to have that setting be http log level, and can be default to debug or something else that isn't on by default?

[himanshug]

@drcrallen that would be ok as well, so basically we write our own Slf4jRequestLog (maybe just extend it) and do logger.degug(..) instead of logger.info(..) instead of having a config in ServerConfig?
another thing I thought (but dint do) was to put POST body also in the log . Jetty implementation doesn't log the request body.

[fjy]

can we document the config?

[drcrallen]

@himanshug : I was thinking just use our normal logging implementation, then if you're needing http debug logs you can enable debug logs in your log4j2.xml for only that class.

[himanshug]

@drcrallen removed the new ServerConfig setting and doing log.debug(..) instead
@fjy updated the doc about setting "io.druid.jetty.RequestLog" to debug level for printing request logs.

[himanshug]

@fjy @drcrallen can you please see and thumbs-up/merge if there are no further comments?

[fjy]

👍

[drcrallen]

👍 Looks very nice. With log4j2 you should be able to open up a jconsole to the jvm with the log4j2 plugin and enable logging dynamically if you wanted to be really fancy on the operational side of this feature.

@himanshug Do you want to squash?

[himanshug]

@drcrallen squashed