More detailed error logging on segment activities #1568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
|
Java 8 + zk atomicity seems keeps breaking, trying for a better travis CI run |
| @@ -63,7 +63,7 @@ public void kill(DataSegment segment) throws SegmentLoadingException | |||
| } | |||
| } | |||
| catch (ServiceException e) { | |||
| throw new SegmentLoadingException(e, "Couldn't kill segment[%s]", segment.getIdentifier()); | |||
| throw new SegmentLoadingException(e, "Couldn't kill segment[%s]: [%s]", segment.getIdentifier(), e); | |||
There was a problem hiding this comment.
"e" is already set as the exception "cause", why do we need to put e.toString() in the message as well or did you want to put e.getMessage() ?
There was a problem hiding this comment.
E as cause only captures stack trace. E as parameters has a lot of info in its toString
himanshug
added a commit
that referenced
this pull request
Jul 28, 2015
More detailed error logging on segment activities
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.