Support for JSON Smile format for EventReceiverFirehoseFactory #1622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nishantmonu51 Do you have data on how much it impacts performance? |
| @@ -115,6 +132,8 @@ public int postEventsFromFile(String file) | |||
| ); | |||
| String s; | |||
| Collection<Map<String, Object>> events = new ArrayList<Map<String, Object>>(); | |||
| // Test sending events using both jsonMapper and smileMapper. | |||
There was a problem hiding this comment.
Can you explain this more?
Support for Smile format for EventReceiverFireshoseFactory. would help in decreasing network load on middle managers ingesting high data volumes. review comments
nishantmonu51
force-pushed
the
smile-eventreceiverfirehose
branch
from
52a1244
to
e6b20db
Compare
|
the major improvement this PR does is improvement in network usage and would help in conserving bandwidth when we run multiple peons in the same machine. |
| ? MediaType.APPLICATION_JSON | ||
| : SmileMediaTypes.APPLICATION_JACKSON_SMILE; | ||
| totalEventsPosted += postEvents(events, mapper, mediaType); | ||
| ; |
|
👍 lgtm. Compression could be cool too in the future, as I recall from testing things in Kafka that smile-lz4 was a good combination of cpu and size. |
drcrallen
added a commit
that referenced
this pull request
Aug 27, 2015
Support for JSON Smile format for EventReceiverFirehoseFactory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for JSON Smile format for EventReceiverFireshoseFactory.
would help in decreasing network load on middle managers ingesting high
data volumes.