Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hopefully add better timeouts and ordering to JDBCExtractionNamespaceTest #1658

Merged

Conversation

drcrallen
Copy link
Contributor

I'll be opening and closing this a few times to see if I can get a failure case for JDBCExtractionNamespaceTest

@drcrallen drcrallen closed this Aug 25, 2015
@drcrallen drcrallen reopened this Aug 25, 2015
@drcrallen drcrallen closed this Aug 25, 2015
@drcrallen drcrallen reopened this Aug 25, 2015
@drcrallen drcrallen force-pushed the cleanupJDBCExtractionNamespaceTest branch from ec50205 to 9a34c54 Compare August 25, 2015 05:06
@drcrallen drcrallen closed this Aug 25, 2015
@drcrallen drcrallen reopened this Aug 25, 2015
@drcrallen drcrallen closed this Aug 25, 2015
@drcrallen drcrallen reopened this Aug 25, 2015
@drcrallen drcrallen closed this Aug 25, 2015
@drcrallen drcrallen reopened this Aug 25, 2015
@drcrallen drcrallen force-pushed the cleanupJDBCExtractionNamespaceTest branch 2 times, most recently from 8117664 to a063a72 Compare August 25, 2015 18:22
@drcrallen drcrallen closed this Aug 25, 2015
@drcrallen drcrallen reopened this Aug 25, 2015
@drcrallen drcrallen closed this Aug 25, 2015
@drcrallen drcrallen reopened this Aug 25, 2015
@drcrallen drcrallen force-pushed the cleanupJDBCExtractionNamespaceTest branch from a063a72 to 299c5bc Compare August 25, 2015 19:40
);
committed.await(10, TimeUnit.SECONDS);
Thread.sleep(2);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason for the sleep here, given that we wait just before?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If latch completes within 1 ms it makes sure a few ms have elapsed. This is to help make sure things which only check on granularity of ms have a few ms spacing to acknowledge timestamp changes..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comments

@drcrallen drcrallen force-pushed the cleanupJDBCExtractionNamespaceTest branch 3 times, most recently from 3c41b27 to 1555763 Compare August 25, 2015 23:38
@drcrallen drcrallen closed this Aug 26, 2015
@drcrallen drcrallen reopened this Aug 26, 2015
@drcrallen drcrallen closed this Aug 26, 2015
@drcrallen drcrallen reopened this Aug 26, 2015
@drcrallen drcrallen closed this Aug 26, 2015
@drcrallen drcrallen reopened this Aug 26, 2015
@drcrallen drcrallen force-pushed the cleanupJDBCExtractionNamespaceTest branch from a767040 to 4582d65 Compare August 26, 2015 04:26
@drcrallen drcrallen force-pushed the cleanupJDBCExtractionNamespaceTest branch from 7bdcbb7 to 24c835e Compare August 26, 2015 06:31
@drcrallen
Copy link
Contributor Author

Failure in SQLMetadataStorageActionHandlerTest.testLocks:227 » CallbackFailed org.skife.j. restarting

@drcrallen drcrallen closed this Aug 26, 2015
@drcrallen drcrallen reopened this Aug 26, 2015
@drcrallen
Copy link
Contributor Author

testDelete(io.druid.server.namespace.cache.NamespaceExtractionCacheManagerExecutorsTest)  Time elapsed: 50.009 sec  <<< ERROR!
java.lang.Exception: test timed out after 50000 milliseconds
    at io.druid.server.namespace.cache.NamespaceExtractionCacheManager.removeNamespaceLocalMetadata(NamespaceExtractionCacheManager.java:296)
    at io.druid.server.namespace.cache.NamespaceExtractionCacheManager.delete(NamespaceExtractionCacheManager.java:514)
    at io.druid.server.namespace.cache.OnHeapNamespaceExtractionCacheManager.delete(OnHeapNamespaceExtractionCacheManager.java:99)
    at io.druid.server.namespace.cache.NamespaceExtractionCacheManagerExecutorsTest.testDelete(NamespaceExtractionCacheManagerExecutorsTest.java:333)
    at io.druid.server.namespace.cache.NamespaceExtractionCacheManagerExecutorsTest.testDelete(NamespaceExtractionCacheManagerExecutorsTest.java:258)
Running io.druid.server.namespace.URIExtractionNamespaceFunctionFactoryTest
Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.641 sec - in io.druid.server.namespace.URIExtractionNamespaceFunctionFactoryTest
Results :
Tests in error: 
  NamespaceExtractionCacheManagerExecutorsTest.testDelete:258->testDelete:333 » 

Failure in another test, restarting to see if I can get a JDBC test failure

@drcrallen drcrallen closed this Aug 26, 2015
@drcrallen drcrallen reopened this Aug 26, 2015
@drcrallen drcrallen force-pushed the cleanupJDBCExtractionNamespaceTest branch from 24c835e to cf2d3ee Compare August 26, 2015 15:23
@drcrallen drcrallen closed this Aug 26, 2015
@drcrallen drcrallen reopened this Aug 26, 2015
@drcrallen drcrallen closed this Aug 26, 2015
@drcrallen drcrallen reopened this Aug 26, 2015
@drcrallen
Copy link
Contributor Author

failed on WorkerTaskMonitorTest.testGetAnnouncements:222 null

@drcrallen drcrallen closed this Aug 26, 2015
@drcrallen drcrallen reopened this Aug 26, 2015
@drcrallen drcrallen force-pushed the cleanupJDBCExtractionNamespaceTest branch from cf2d3ee to df69d94 Compare August 26, 2015 18:36
@drcrallen drcrallen force-pushed the cleanupJDBCExtractionNamespaceTest branch from df69d94 to ac8e32b Compare August 27, 2015 06:06
@drcrallen drcrallen closed this Aug 29, 2015
@drcrallen drcrallen reopened this Aug 29, 2015
@drcrallen drcrallen closed this Sep 1, 2015
@drcrallen drcrallen reopened this Sep 1, 2015
@drcrallen drcrallen closed this Sep 1, 2015
@drcrallen drcrallen reopened this Sep 1, 2015
@drcrallen
Copy link
Contributor Author

This seems to be in a pretty good state overall.

@xvrl
Copy link
Member

xvrl commented Sep 2, 2015

👍

1 similar comment
@nishantmonu51
Copy link
Member

+1

nishantmonu51 added a commit that referenced this pull request Sep 2, 2015
Hopefully add better timeouts and ordering to JDBCExtractionNamespaceTest
@nishantmonu51 nishantmonu51 merged commit 0096e6a into apache:master Sep 2, 2015
@drcrallen drcrallen deleted the cleanupJDBCExtractionNamespaceTest branch September 2, 2015 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants