Redirect fixes #1778
Merged
Redirect fixes #1778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gianm
commented
Sep 25, 2015
gianm
commented
- Fix overlord redirect's ability to detect that there is no leader.
- Change the 302 to 307 so user agents are more likely to preserve the method (POST -> POST instead of POST -> GET)
|
👍 |
| @@ -45,8 +47,17 @@ public boolean doLocal() | |||
| @Override | |||
| public URL getRedirectURL(String queryString, String requestURI) | |||
| { | |||
| if (!requestURI.startsWith("/")) { | |||
There was a problem hiding this comment.
is this even necessary given that we use new URI(...) ?
gianm
force-pushed
the
redirect-fixes
branch
from
3ebde0a
to
3481722
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.