Server discovery selector ipv6 friendly #1811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drcrallen
changed the title
| Assert.assertTrue(server.getHost().contains(new Integer(PORT).toString())); | ||
| Assert.assertTrue(server.getHost().contains(ADDRESS)); | ||
| Assert.assertEquals(new String("http"), server.getScheme()); | ||
| EasyMock.verify(instance,serviceProvider); | ||
| EasyMock.verify(instance, serviceProvider); | ||
| final URI uri = new URI(String.format("%s://%s%s", server.getScheme(), server.getHost(), "/druid/indexer/v1/action")); |
There was a problem hiding this comment.
since this PR is about removing potentially bad String.format assumptions, let's use new URI(scheme, host, path, null) instead of String.format here :)
There was a problem hiding this comment.
I did it here because that's the method used elsewhere.
There was a problem hiding this comment.
io.druid.indexing.common.actions.RemoteTaskActionClient#makeServiceUri
There was a problem hiding this comment.
io.druid.server.router.CoordinatorRuleManager#getRuleURL
There was a problem hiding this comment.
io.druid.client.indexing.IndexingServiceClient#baseUrl
…directly instead of using String.format
drcrallen
force-pushed
the
ServerDiscoverySelectorIPv6
branch
from
8bbd068
to
bf11723
Compare
|
👍 |
|
👍 |
nishantmonu51
added a commit
that referenced
this pull request
Oct 13, 2015
Server discovery selector ipv6 friendly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.