support multiple non-consecutive intervals in outer query of nested group-by #1822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| outerQuery, | ||
| new IncrementalIndexStorageAdapter( | ||
| index | ||
| Sequences.concat( |
There was a problem hiding this comment.
a comment would be nice here to explain why this is done.
himanshug
force-pushed
the
outer_query_multiple_interval_fix
branch
from
ab68a71
to
490de1f
Compare
|
👍 |
1 similar comment
|
👍 |
xvrl
added a commit
that referenced
this pull request
Oct 13, 2015
…_fix support multiple non-consecutive intervals in outer query of nested group-by
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently it fails with, "Null storage adapter found. Probably trying to issue a query against a segment being memory unmapped."