[WIP] druid-hive integration #2880
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navis
force-pushed
the
hive-druid-integration
branch
from
ba464b5
to
25cc89b
Compare
| long maxSize = conf.getLong(CONF_MAX_SPLIT_SIZE, DEFAULT_MAX_SPLIT_SIZE); | ||
|
|
||
| if (maxSize > 0) { | ||
| Collections.shuffle(segments); |
There was a problem hiding this comment.
I am just wondering it is necessary to shuffle the segments list?
|
@navis it's a bit confusing to have the same code changes in two different PRs. We're getting comments in both, which makes it hard to track the ones that are addressed or not. Maybe we should close one of the PRs? |
|
@xvrl Sorry, I thought WIP in title can make others skip reviewing. I'll close this, for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #2282. This is the first try to integrate druid with hive.
tested on hive-2.0 with MR/TEZ. needs configuration
hive.optimize.index.filter=true(hive-site.xml) andmapreduce.job.user.classpath.first=true(hadoop mapred-site.xml)