Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lisp Local is doing the same task #88

Closed
guicho271828 opened this issue Oct 12, 2018 · 4 comments
Closed

Lisp Local is doing the same task #88

guicho271828 opened this issue Oct 12, 2018 · 4 comments

Comments

@guicho271828
Copy link
Contributor

It is not breaking the benchmark, it is just helping the compiler to get the optimized code.

@drujensen
Copy link
Owner

ok. I would prefer only one version for the regular benchmark that matches as close as possible to the other code examples.

Do you want to replace the fib.lisp with optimized/fib-local.lisp?

@guicho271828
Copy link
Contributor Author

guicho271828 commented Oct 13, 2018

I think I am fine if the description

They do not perform the same internal tasks as the other examples

is changed to something like

They do not have the syntactically equivalent code as the base examples. Some does not perform the same internal tasks as the other examples

and those that do the different internal tasks are explicitly marked as so, or come with description of what type of technique was used.
by the way, I can contribute the memoized version of lisp too.

@drujensen
Copy link
Owner

aah, I see. yeah, It's kinda strange having a 7s optimized version. It really doesn't fit in the optimized category. If you don't want to replace the primary benchmark with this, can we remove this example?

by the way, I can contribute the memoized version of lisp too.

It would be great to have a fib-rem.lisp example.

@drujensen
Copy link
Owner

I removed this so it didn't show up as 7 seconds in the optimized section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants