Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symlink .editorconfig and .gitattributesscaffolding from web/ to project root #220

Closed
ak5 opened this issue Nov 18, 2016 · 4 comments
Closed

Comments

@ak5
Copy link

ak5 commented Nov 18, 2016

Hi,

First off, nice project - thanks!

I was wondering if the files below have to be in web/ - it seems to me like they should be in the project root.

web/.csslintrc
web/.editorconfig
web/.eslintignore
web/.eslintrc
web/.gitattributes

For example, web/.editorconfg has some settings for composer.json which wouldn't be applied afaik.

@webflo
Copy link
Member

webflo commented Nov 18, 2016

It makes sense for a few files but not all of them. http://cgit.drupalcode.org/drupal/tree/.eslintignore contains from paths which will be invalid if we move the file around.

@ak5
Copy link
Author

ak5 commented Nov 21, 2016

Although that could be remedied by prefixing each line with web/? Maybe I am being pedantic hah

@mfernea
Copy link

mfernea commented May 5, 2017

As custom code should go under /web folder, css & js lint can stay where they are, and I guess only .editorconfig and .gitattributes should be moved (symlinked) in root.

@leymannx leymannx changed the title scaffolding - hidden files in web/ Symlink .editorconfig and .gitattributesscaffolding from web/ to project root Jan 12, 2021
@AlexSkrypnyk
Copy link
Collaborator

This pull request/issue has been inactive for over a year and is being closed due to inactivity. If the issue still persists or the contribution is still relevant, please feel free to reopen it or create a new one.

Thank you for your understanding and your contributions to the project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants