Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcoded public files dir #295

Closed
dillix opened this issue Aug 11, 2017 · 4 comments
Closed

Hardcoded public files dir #295

dillix opened this issue Aug 11, 2017 · 4 comments

Comments

@dillix
Copy link

dillix commented Aug 11, 2017

I changed public files dir in settings.php to /uploads, but when I try to install new module thought composer I get following error:

[Symfony\Component\Filesystem\Exception\IOException]                                    
  Failed to create "/Users/maxpro/Sites/site.dev/htdocs/web/sites/default/files"  

After investigation I found problem in /scripts/composer/ScriptHandler.php
Why public files dir hardcoded here?

@webflo
Copy link
Member

webflo commented Aug 12, 2017

Your use case makes sense, it is there to prepare the site for initial installation.

@webflo
Copy link
Member

webflo commented Aug 12, 2017

(Starting a project from scratch via composer create-project)

@dillix
Copy link
Author

dillix commented Aug 15, 2017

@webflo I started project from scratch, then I changed files public dir in drupal settings.php, but then I run composer require drupal/[module name], I get errors, after investigation I've found that files public dir hardcoded in ScriptHandler.php. I think this is a bug. Can we read files public dir from drupal settings.php?

@leymannx
Copy link
Collaborator

Inactive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants