Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation Notice: drupal_rewrite_settings() is deprecated in drupal:10.1.0 in ScriptHandler.php #626

Closed
AlexSkrypnyk opened this issue Jul 27, 2023 · 6 comments · Fixed by #634

Comments

@AlexSkrypnyk
Copy link
Collaborator

AlexSkrypnyk commented Jul 27, 2023

Drupal 10.1.x added SettingsEditor class and a deprecation notice for drupal_rewrite_settings().

Deprecation Notice: drupal_rewrite_settings() is deprecated in drupal:10.1.0 and is removed from drupal:11.0.0. Use SettingsEditor::rewrite() instead. The order of the arguments has also changed: $settings_file is now required and is the first argument of the method. See https://www.drupal.org/node/3244583 in /app/web/core/includes/install.inc:265
Created a sites/default/settings.php file with chmod 0666

We need to update the ScriptHandler.php to use SettingsEditor::rewrite() instead.

Should we still support drupal_rewrite_settings() for sites using core <10.1.x?

@AlexSkrypnyk
Copy link
Collaborator Author

We can still support drupal_rewrite_settings() for sites using core <10.1.x like so

Cursor_and_Updated_ScriptHandler__by_AlexSkrypnyk_·_Pull_Request__942_·_drevops_drevops

Happy to provide a PR

@AlexSkrypnyk
Copy link
Collaborator Author

bump

@AlexSkrypnyk
Copy link
Collaborator Author

@leymannx
is this something that the project would be interested to have updated? I'm happy to provide a PR

@leymannx
Copy link
Collaborator

@AlexSkrypnyk - Oh yes, that would be great. And if we bump everything properly we don't even need the class check.

@leymannx
Copy link
Collaborator

Ah yeah, we bumped already to 10.2, so no class check needed.

@AlexSkrypnyk
Copy link
Collaborator Author

@leymannx
done.
#634
please review. thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants