Skip to content

Commit

Permalink
Issue #3155462 by andrewmacpherson: Remove landmark region role from …
Browse files Browse the repository at this point in the history
…Powered-by-Drupal block

(cherry picked from commit 47a7b73659fddaea8c6fde912999d8cbe456aac0)
  • Loading branch information
alexpott committed Jul 21, 2020
1 parent c0034af commit 22ceb2d
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 13 deletions.
4 changes: 0 additions & 4 deletions modules/system/system.module
Original file line number Diff line number Diff line change
Expand Up @@ -869,10 +869,6 @@ function system_preprocess_block(&$variables) {
];
}
break;

case 'system_powered_by_block':
$variables['attributes']['role'] = 'complementary';
break;
}
}

Expand Down
10 changes: 1 addition & 9 deletions profiles/standard/tests/src/Functional/StandardTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,7 @@ public function testStandard() {
$this->drupalGet('');
$this->assertText('Main navigation');

// Verify we have role = aria on system_powered_by and help_block
// blocks.
// Verify we have role = complementary on help_block blocks.
$this->drupalGet('admin/structure/block');
$elements = $this->xpath('//div[@role=:role and @id=:id]', [
':role' => 'complementary',
Expand All @@ -71,13 +70,6 @@ public function testStandard() {

$this->assertCount(1, $elements, 'Found complementary role on help block.');

$this->drupalGet('');
$elements = $this->xpath('//div[@role=:role and @id=:id]', [
':role' => 'complementary',
':id' => 'block-bartik-powered',
]);
$this->assertCount(1, $elements, 'Found complementary role on powered by block.');

// Verify anonymous user can see the block.
$this->drupalLogout();
$this->assertText('Main navigation');
Expand Down

0 comments on commit 22ceb2d

Please sign in to comment.