Skip to content

Commit

Permalink
Issue #3139132 by Beakerboy, daffie: Query uses hardcoded LIMIT inste…
Browse files Browse the repository at this point in the history
…ad of queryRange()

(cherry picked from commit a8a6638ec740fc227a702203483048e1067e6ade)
  • Loading branch information
alexpott committed Jun 13, 2020
1 parent 66ed69f commit 3da9d32
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion modules/big_pipe/tests/src/Functional/BigPipeTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,9 @@ public function testBigPipe() {

// Verify that the two expected exceptions are logged as errors.
$this->assertEqual($log_count + 2, $connection->query('SELECT COUNT(*) FROM {watchdog}')->fetchField(), 'Two new watchdog entries.');
$records = $connection->query('SELECT * FROM {watchdog} ORDER BY wid DESC LIMIT 2')->fetchAll();
// Using the method queryRange() allows contrib database drivers the ability
// to insert their own limit and offset functionality.
$records = $connection->queryRange('SELECT * FROM {watchdog} ORDER BY wid DESC', 0, 2)->fetchAll();
$this->assertEqual(RfcLogLevel::ERROR, $records[0]->severity);
$this->assertStringContainsString('Oh noes!', (string) unserialize($records[0]->variables)['@message']);
$this->assertEqual(RfcLogLevel::ERROR, $records[1]->severity);
Expand Down

0 comments on commit 3da9d32

Please sign in to comment.