Skip to content

Commit

Permalink
Issue #3161301 by jungle, bbrala, alexpott: Fix typo "existant" in Core
Browse files Browse the repository at this point in the history
(cherry picked from commit b928c0cf17722961750438c716fa6150c17714ae)
  • Loading branch information
alexpott committed Jul 31, 2020
1 parent 7557be2 commit 408f827
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 14 deletions.
6 changes: 3 additions & 3 deletions modules/migrate/tests/src/Unit/RowTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -405,15 +405,15 @@ public function getMultipleDataProvider() {
'destination_value_3',
],
],
'Mix of keys including non-existant' => [
'Mix of keys including non-existent' => [
'keys' => [
'shared_key_1',
'@shared_key_1',
'@@shared_key_2',
'@@@shared_key_2',
'@@@@@@@@@shared_key_3',
'non_existant_source_key',
'@non_existant_destination_key',
'non_existent_source_key',
'@non_existent_destination_key',
],
'values' => [
'source_shared_value_1',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ public function testGetForCircularServices() {
* @covers ::getAlternatives
* @covers ::getServiceAlternatives
*/
public function testGetForNonExistantService() {
public function testGetForNonExistentService() {
$this->expectException(ServiceNotFoundException::class);
$this->container->get('service_not_exists');
}
Expand Down Expand Up @@ -286,7 +286,7 @@ public function testGetForSerializedServiceDefinition() {
* @covers ::createService
* @covers ::resolveServicesAndParameters
*/
public function testGetForNonExistantParameterDependency() {
public function testGetForNonExistentParameterDependency() {
$service = $this->container->get('service_parameter_not_exists', ContainerInterface::NULL_ON_INVALID_REFERENCE);
$this->assertNull($service, 'Service is NULL.');
}
Expand Down Expand Up @@ -315,7 +315,7 @@ public function testGetForParameterDependencyWithExceptionOnSecondCall() {
* @covers ::createService
* @covers ::resolveServicesAndParameters
*/
public function testGetForNonExistantParameterDependencyWithException() {
public function testGetForNonExistentParameterDependencyWithException() {
$this->expectException(InvalidArgumentException::class);
$this->container->get('service_parameter_not_exists');
}
Expand All @@ -327,7 +327,7 @@ public function testGetForNonExistantParameterDependencyWithException() {
* @covers ::createService
* @covers ::resolveServicesAndParameters
*/
public function testGetForNonExistantServiceDependency() {
public function testGetForNonExistentServiceDependency() {
$service = $this->container->get('service_dependency_not_exists', ContainerInterface::NULL_ON_INVALID_REFERENCE);
$this->assertNull($service, 'Service is NULL.');
}
Expand All @@ -340,7 +340,7 @@ public function testGetForNonExistantServiceDependency() {
* @covers ::resolveServicesAndParameters
* @covers ::getAlternatives
*/
public function testGetForNonExistantServiceDependencyWithException() {
public function testGetForNonExistentServiceDependencyWithException() {
$this->expectException(ServiceNotFoundException::class);
$this->container->get('service_dependency_not_exists');
}
Expand All @@ -351,7 +351,7 @@ public function testGetForNonExistantServiceDependencyWithException() {
* @covers ::get
* @covers ::createService
*/
public function testGetForNonExistantServiceWhenUsingNull() {
public function testGetForNonExistentServiceWhenUsingNull() {
$this->assertNull($this->container->get('service_not_exists', ContainerInterface::NULL_ON_INVALID_REFERENCE), 'Not found service does not throw exception.');
}

Expand All @@ -360,7 +360,7 @@ public function testGetForNonExistantServiceWhenUsingNull() {
* @covers ::get
* @covers ::createService
*/
public function testGetForNonExistantNULLService() {
public function testGetForNonExistentNULLService() {
$this->expectException(ServiceNotFoundException::class);
$this->container->get(NULL);
}
Expand All @@ -371,7 +371,7 @@ public function testGetForNonExistantNULLService() {
* @covers ::get
* @covers ::createService
*/
public function testGetForNonExistantServiceMultipleTimes() {
public function testGetForNonExistentServiceMultipleTimes() {
$container = new $this->containerClass();

$this->assertNull($container->get('service_not_exists', ContainerInterface::NULL_ON_INVALID_REFERENCE), 'Not found service does not throw exception.');
Expand All @@ -385,7 +385,7 @@ public function testGetForNonExistantServiceMultipleTimes() {
* @covers ::createService
* @covers ::getAlternatives
*/
public function testGetForNonExistantServiceWithExceptionOnSecondCall() {
public function testGetForNonExistentServiceWithExceptionOnSecondCall() {
$this->assertNull($this->container->get('service_not_exists', ContainerInterface::NULL_ON_INVALID_REFERENCE), 'Not found service does nto throw exception.');
$this->expectException(ServiceNotFoundException::class);
$this->container->get('service_not_exists');
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ public function testGetDefinition() {
]
));

$this->assertNull($this->hookDiscovery->getDefinition('test_non_existant', FALSE));
$this->assertNull($this->hookDiscovery->getDefinition('test_non_existent', FALSE));

$plugin_definition = $this->hookDiscovery->getDefinition('test_id_1');
$this->assertEquals($plugin_definition['class'], 'Drupal\plugin_test\Plugin\plugin_test\fruit\Apple');
Expand All @@ -126,7 +126,7 @@ public function testGetDefinitionWithUnknownID() {
->will($this->returnValue([]));

$this->expectException(PluginNotFoundException::class);
$this->hookDiscovery->getDefinition('test_non_existant', TRUE);
$this->hookDiscovery->getDefinition('test_non_existent', TRUE);
}

protected function hookDiscoveryTestTestPlugin() {
Expand Down

0 comments on commit 408f827

Please sign in to comment.