Skip to content

Commit

Permalink
Revert "Issue #3143316 by Lendude, sunset_bill, daffie, xjm, facine: …
Browse files Browse the repository at this point in the history
…"Getting the base fields is not supported for entity type" exception in ViewsConfigUpdater"

This reverts commit 15e0b54c86ee8b7cb96237d9b9219e9a34318b6b.
  • Loading branch information
xjm committed Jun 22, 2020
1 parent 36d870b commit 47e0dae
Show file tree
Hide file tree
Showing 6 changed files with 1 addition and 74 deletions.
3 changes: 1 addition & 2 deletions modules/views/src/ViewsConfigUpdater.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
use Drupal\Core\DependencyInjection\ContainerInjectionInterface;
use Drupal\Core\Entity\EntityFieldManagerInterface;
use Drupal\Core\Entity\EntityTypeManagerInterface;
use Drupal\Core\Entity\FieldableEntityInterface;
use Drupal\Core\Entity\Sql\DefaultTableMapping;
use Symfony\Component\DependencyInjection\ContainerInterface;

Expand Down Expand Up @@ -286,7 +285,7 @@ protected function getMultivalueBaseFieldUpdateTableInfo() {
$table_info = [];

foreach ($this->entityTypeManager->getDefinitions() as $entity_type_id => $entity_type) {
if ($entity_type->hasHandlerClass('views_data') && $entity_type->entityClassImplements(FieldableEntityInterface::class)) {
if ($entity_type->hasHandlerClass('views_data')) {
$base_field_definitions = $this->entityFieldManager->getBaseFieldDefinitions($entity_type_id);

$entity_storage = $this->entityTypeManager->getStorage($entity_type_id);
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

5 changes: 0 additions & 5 deletions modules/views/tests/src/Kernel/ViewsConfigUpdaterTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,6 @@ class ViewsConfigUpdaterTest extends ViewsKernelTestBase {
*/
protected $configUpdater;

/**
* {@inheritdoc}
*/
protected static $modules = ['views_config_entity_test'];

/**
* {@inheritdoc}
*/
Expand Down

0 comments on commit 47e0dae

Please sign in to comment.