Issue #3109795 by alexpott, Berdir: Entity plural label context is no…

…t set as expected (cherry picked from commit 5002f8f786f6d93a8db35a36f9c221438fa83c8c)
drupal · Jun 1, 2020 · 553d63f · 553d63f
1 parent f0ea15c
commit 553d63f
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/lib/Drupal/Core/Entity/EntityType.php b/lib/Drupal/Core/Entity/EntityType.php
@@ -821,8 +821,11 @@ public function getCountLabel($count) {
     if (empty($this->label_count)) {
       return $this->formatPlural($count, '@count @label', '@count @label entities', ['@label' => $this->getSingularLabel()], ['context' => 'Entity type label']);
     }
-    $context = isset($this->label_count['context']) ? $this->label_count['context'] : 'Entity type label';
-    return $this->formatPlural($count, $this->label_count['singular'], $this->label_count['plural'], ['context' => $context]);
+    $options = [];
+    if (isset($this->label_count['context'])) {
+      $options['context'] = $this->label_count['context'];
+    }
+    return $this->formatPlural($count, $this->label_count['singular'], $this->label_count['plural'], [], $options);
   }
 
   /**

diff --git a/tests/Drupal/Tests/Core/Entity/EntityTypeTest.php b/tests/Drupal/Tests/Core/Entity/EntityTypeTest.php
@@ -397,6 +397,12 @@ public function testGetCountLabel() {
     $this->assertEquals('one entity test', $entity_type->getCountLabel(1));
     $this->assertEquals('2 entity test', $entity_type->getCountLabel(2));
     $this->assertEquals('200 entity test', $entity_type->getCountLabel(200));
+    $this->assertArrayNotHasKey('context', $entity_type->getCountLabel(1)->getOptions());
+
+    // Test a custom context.
+    $entity_type = $this->setUpEntityType(['label_count' => ['singular' => 'one entity test', 'plural' => '@count entity test', 'context' => 'custom context']]);
+    $entity_type->setStringTranslation($this->getStringTranslationStub());
+    $this->assertSame('custom context', $entity_type->getCountLabel(1)->getOption('context'));
   }
 
   /**
@@ -408,6 +414,7 @@ public function testGetCountLabelDefault() {
     $this->assertEquals('1 entity test plural', $entity_type->getCountLabel(1));
     $this->assertEquals('2 entity test plural entities', $entity_type->getCountLabel(2));
     $this->assertEquals('200 entity test plural entities', $entity_type->getCountLabel(200));
+    $this->assertSame('Entity type label', $entity_type->getCountLabel(1)->getOption('context'));
   }
 
   /**